🛡️ Sentinel: [HIGH] Fix untrusted code execution via git config#77
🛡️ Sentinel: [HIGH] Fix untrusted code execution via git config#77tachyon-beep wants to merge 1 commit into
Conversation
Mitigated risk of executing untrusted code when invoking `git` via subprocess by explicitly disabling fsmonitor via `_SAFE_GIT_CONFIG = ("-c", "core.fsmonitor=false")`. Applied this to `src/wardline/core/delta.py` and `src/wardline/core/legis.py`.
Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Potential untrusted local code execution via malicious
.git/configfiles (e.g.core.fsmonitor) when invokinggitsubprocess commands insrc/wardline/core/delta.pyandsrc/wardline/core/legis.py.🎯 Impact: An attacker could execute arbitrary code by placing a malicious
.git/configin a directory scanned by Wardline.🔧 Fix: Added
_SAFE_GIT_CONFIG = ("-c", "core.fsmonitor=false")to allgitsubprocess calls indelta.pyandlegis.py, aligning with the existing mitigation found inattest.pyandattest_key.py. Fixed tests to expect the new arguments.✅ Verification: Ran
make test, all unit tests pass including the patchedtest_delta.py.PR created automatically by Jules for task 1566641735470158710 started by @tachyon-beep